Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config/containers-and-vms/lxc: document incus #815

Merged
merged 1 commit into from
Jan 3, 2025

Conversation

duskmoss
Copy link
Contributor

Incus is the current community tool for easy LXC administration. LXD has been moved to canonical, relicensed (Apache 2.0 to AGPL3) and contributors are asked to sign a CLA.

LXD package in repos is out of date, but incus is up to date. I thought we should have docs for this package.

For now I've left the LXD section in as ahesford recommended on IRC.

@duskmoss duskmoss changed the title add Incus to LXC page lxc.md: add Incus to LXC page Sep 29, 2024
Copy link
Member

@classabbyamp classabbyamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mostly copyediting review as I don't know much about incus

src/config/containers-and-vms/lxc.md Outdated Show resolved Hide resolved
src/config/containers-and-vms/lxc.md Outdated Show resolved Hide resolved
src/config/containers-and-vms/lxc.md Outdated Show resolved Hide resolved
src/config/containers-and-vms/lxc.md Outdated Show resolved Hide resolved
src/config/containers-and-vms/lxc.md Outdated Show resolved Hide resolved
src/config/containers-and-vms/lxc.md Outdated Show resolved Hide resolved
src/config/containers-and-vms/lxc.md Outdated Show resolved Hide resolved
Copy link
Contributor

@0x5c 0x5c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that incus-user will initialize the default incus profile when it is started. To avoid default configuration initialize incus for youself with incus admin init before enabling incus-user.

I spent multiple days trying to figure out what was going on with incus automatically creating a new zfs pool, thanks for saving me from going mad :D

src/config/containers-and-vms/lxc.md Outdated Show resolved Hide resolved
src/config/containers-and-vms/lxc.md Outdated Show resolved Hide resolved
@0x5c
Copy link
Contributor

0x5c commented Dec 19, 2024

There's two remaining bits of documentation in the README.voidlinux file that if added here would render it completely unnecessary.

The root user should also be assigned a range of subordinate user and group IDs to be mapped in
containers.
For example, the command

usermod --add-subuids 1000000-1065535 \
	--add-subgids 1000000-1065535 root

will assign a range of 65,536 IDs for users and groups.

The sub{u,g}id stuff is mentioned vaguely (with different values and the manual method) in the LXC section, but there's no indication that one would need to follow the instruction in the LXC section, nor good indication at to what it means in practice Maybe this could be refactored into a section that both the LXC and Incus sections link to.

Optional dependencies:

To run virtual machines, install qemu and edk2-ovmf.
To run OCI containers, install spokeo and umoci.

@duskmoss
Copy link
Contributor Author

duskmoss commented Dec 19, 2024

There's two remaining bits of documentation in the README.voidlinux file that if added here would render it completely unnecessary.

IIRC I didn't include the Subuids/gids info because it's actually not neccesary, these are setup in void by default. I did make a lot to remove from the readme but maintainer wanted to keep.

@0x5c
Copy link
Contributor

0x5c commented Dec 19, 2024

Interesting, the only range that was setup without my intervention was for my user, not root. What part of void would be setting that up automatically?

@duskmoss
Copy link
Contributor Author

@0x5c
Copy link
Contributor

0x5c commented Dec 19, 2024

Weirdly, that was added 5 years ago and my install is not that old, I guess something to investigate separately from this issue

@duskmoss
Copy link
Contributor Author

I'll try and confirm at some point, but eitherway, it's in the readme.

I think optional dependencies should stay in the readme, it's much easier to update them when the package is updated than keeping the documentation in sync. And it's the standard place for void, like with the steam package.

I'll get the edits talked about here worked on either today or tomorrow.

@duskmoss duskmoss force-pushed the incus-doc branch 2 times, most recently from b389d55 to cbbc3bc Compare December 21, 2024 18:55
src/config/containers-and-vms/lxc.md Outdated Show resolved Hide resolved
src/config/containers-and-vms/lxc.md Outdated Show resolved Hide resolved
src/config/containers-and-vms/lxc.md Outdated Show resolved Hide resolved
src/config/containers-and-vms/lxc.md Outdated Show resolved Hide resolved
src/config/containers-and-vms/lxc.md Show resolved Hide resolved
@duskmoss duskmoss force-pushed the incus-doc branch 2 times, most recently from 1ccf574 to f59339a Compare December 21, 2024 19:51
@classabbyamp
Copy link
Member

I think optional dependencies should stay in the readme, it's much easier to update them when the package is updated than keeping the documentation in sync.

a pr to void-docs updating that kind of thing can be merged quickly, but it is also valuable to have them in README.voidlinux for history.

Can we put them in both places?

@duskmoss
Copy link
Contributor Author

duskmoss commented Jan 2, 2025

Sure

@classabbyamp
Copy link
Member

classabbyamp commented Jan 3, 2025

and btw, commit message should be config/containers-and-vms/lxc: document incus or something like that

@duskmoss
Copy link
Contributor Author

duskmoss commented Jan 3, 2025

and btw, commit message should be config/containers-and-vms/lxc: document incus or something like that

Thanks! Maybe the contribution docs should be more clear about what you want for because path, and file name with extension removed is not something I would have gotten from

    thanks to below for copy edit/review
        Co-authored-by: classabbyamp <[email protected]>
        Co-authored-by: 0x5c <[email protected]>
@duskmoss duskmoss changed the title lxc.md: add Incus to LXC page config/containers-and-vms/lxc: document incus Jan 3, 2025
@classabbyamp classabbyamp merged commit e5a1e83 into void-linux:master Jan 3, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

3 participants