Merge pull request #7 from domcleal/6-ignore-resource-metaparams

Ignore 'require' function name appearing in resource parameters
voxpupuli · Jun 23, 2016 · dcbcf1f · dcbcf1f
2 parents 69cfe96 + c4355ef
commit dcbcf1f
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 0 deletions.
diff --git a/lib/puppet-lint/plugins/check_absolute_classname.rb b/lib/puppet-lint/plugins/check_absolute_classname.rb
@@ -2,6 +2,7 @@
   def check
     tokens.each_with_index do |token, token_idx|
       if token.type == :NAME && ['include','contain','require'].include?(token.value)
+        next if resource_indexes.any? { |resource| resource[:tokens].include?(token) }
         s = token.next_code_token
         in_function = 0
         while s.type != :NEWLINE

diff --git a/spec/puppet-lint/plugins/check_absolute_classname/relative_classname_inclusion_spec.rb b/spec/puppet-lint/plugins/check_absolute_classname/relative_classname_inclusion_spec.rb
@@ -64,6 +64,21 @@ class { 'foobar': }
         expect(problems).to contain_warning(msg).on_line(7).in_column(17)
       end
     end
+
+    context 'when the require metadata parameter is used' do
+      let(:code) do
+        <<-EOS
+        file { '/path':
+          ensure  => present,
+          require => Shellvar['http_proxy'],
+        }
+        EOS
+      end
+
+      it 'should detect no problems' do
+        expect(problems).to have(0).problems
+      end
+    end
   end
 
   context 'with fix enabled' do