Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PostgreSQL: only show databases you can access #475

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
PostgreSQL: only show databases you can access
When connecting to a PostgreSQL database, Adminer's dropdown also includes all databases you don't have access to, which is not very useful. This commit filters out databases that you don't have the USAGE privilege on, to present a cleaner overview of available databases.
  • Loading branch information
thomas-daniels authored Jul 31, 2023

Verified

This commit was signed with the committer’s verified signature.
Rjvs Robert J Spencer
commit d6c467cb96ccbfb26a9a6c491bf6cfb5a7e02c2b
2 changes: 1 addition & 1 deletion adminer/drivers/pgsql.inc.php
Original file line number Diff line number Diff line change
@@ -274,7 +274,7 @@ function connect() {
}

function get_databases() {
return get_vals("SELECT datname FROM pg_database WHERE has_database_privilege(datname, 'CONNECT') ORDER BY datname");
return get_vals("SELECT datname FROM pg_database pd JOIN pg_roles pr on pd.datdba = pr.oid WHERE pg_has_role(pr.rolname, 'USAGE') ORDER BY datname");
}

function limit($query, $where, $limit, $offset = 0, $separator = " ") {