Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VUFIND-1673 Set unique labels for checkboxes #3552

Open
wants to merge 10 commits into
base: dev
Choose a base branch
from
Prev Previous commit
Fix bootstrap5
  • Loading branch information
maccabeelevine committed Oct 23, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
commit e5db19d0fb441593804a60c84bb8c62fc7ae81c1
2 changes: 1 addition & 1 deletion themes/bootstrap5/templates/myresearch/checkedout.phtml
Original file line number Diff line number Diff line change
@@ -110,7 +110,7 @@
<?php if (isset($ilsDetails['renewable']) && $ilsDetails['renewable'] && isset($ilsDetails['renew_details'])): ?>
<?php $safeId = preg_replace('/[^a-zA-Z0-9]/', '', $ilsDetails['renew_details']); ?>
<label>
<input class="checkbox-select-item" type="checkbox" name="renewSelectedIDS[]" value="<?=$this->escapeHtmlAttr($ilsDetails['renew_details'])?>" id="checkbox_<?=$safeId?>" aria-label="<?=$this->escapeHtmlAttr($ilsDetails['title'])?>">
<input class="checkbox-select-item" type="checkbox" name="renewSelectedIDS[]" value="<?=$this->escapeHtmlAttr($ilsDetails['renew_details'])?>" id="checkbox_<?=$safeId?>" aria-labelledby="<?=$this->record($resource)->getUniqueHtmlElementId()?>">
</label>
<input type="hidden" name="selectAllIDS[]" value="<?=$this->escapeHtmlAttr($ilsDetails['renew_details'])?>">
<input type="hidden" name="renewAllIDS[]" value="<?=$this->escapeHtmlAttr($ilsDetails['renew_details'])?>">
Loading