Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade MySQL JDBC .jar; raise minimum MySQL requirement to 8. #4162

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

demiankatz
Copy link
Member

@demiankatz demiankatz commented Dec 16, 2024

Our MySQL JDBC jar was very old; since no version of MySQL 5 is still being supported by the community, it is time to raise our minimum version to 8 and update the connector. This also seems to resolve some strange problems observed during testing of #4108.

Note that the connector class name has changed slightly, and this PR addresses that in addition to updating the jar file.

TODO:

  • Update changelog and requirements wiki pages when merging

@demiankatz demiankatz added the dependencies Pull requests that update a dependency file label Dec 16, 2024
@demiankatz demiankatz added this to the 11.0 milestone Dec 16, 2024
Copy link
Contributor

@EreMaijala EreMaijala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All tests passing! Tested with MariaDB 10.11 and OpenJDK 11.

@demiankatz
Copy link
Member Author

Thanks, @EreMaijala!

@demiankatz demiankatz merged commit c6ff844 into vufind-org:dev Dec 16, 2024
6 checks passed
@demiankatz demiankatz deleted the upgrade-mysql-connector branch December 16, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants