Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use annotations for forward-compatibility with Symfony/Console 7. #19

Merged
merged 2 commits into from
Mar 8, 2024
+8 −4
Merged

Use annotations for forward-compatibility with Symfony/Console 7. #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b3f04a3
Use annotations for forward-compatibility with Symfony/Console 7.
demiankatz Mar 7, 2024
fe5aa9b
Update CHANGELOG.md
demiankatz Mar 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ All notable changes to this project will be documented in this file, in reverse

### Added

- Nothing.
- Compatibility with Symfony/Console versions 6 and 7.

### Changed

Expand All @@ -18,7 +18,7 @@ All notable changes to this project will be documented in this file, in reverse

### Removed

- Nothing.
- Compatibility with Symfony/Console versions less than 5.3.

## Fixed

Expand Down
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
"require": {
"php": ">=8.0",
"laminas/laminas-http": ">=2.2",
"symfony/console": "^4.0||^5.0"
"symfony/console": "^5.3||^6||^7"
},
"require-dev": {
"friendsofphp/php-cs-fixer": "3.26.1",
Expand Down
6 changes: 5 additions & 1 deletion src/OaiPmh/HarvesterCommand.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@
namespace VuFindHarvest\OaiPmh;

use Laminas\Http\Client;
use Symfony\Component\Console\Attribute\AsCommand;
use Symfony\Component\Console\Command\Command;
use Symfony\Component\Console\Input\InputArgument;
use Symfony\Component\Console\Input\InputInterface;
Expand All @@ -48,6 +49,10 @@
* @license http://opensource.org/licenses/gpl-2.0.php GNU General Public License
* @link https://vufind.org/wiki/indexing:oai-pmh Wiki
*/
#[AsCommand(
name: 'harvest/harvest_oai',
description: 'OAI-PMH harvester'
)]
class HarvesterCommand extends Command
{
use WriterAwareTrait;
Expand Down Expand Up @@ -122,7 +127,6 @@ public function __construct(
protected function configure()
{
$this
->setDescription('OAI-PMH harvester')
->setHelp('Harvests metadata using the OAI-PMH protocol.')
->addArgument(
'target',
Expand Down
Loading