Require that CBOR encoding of components MUST NOT use tags. #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…st vectors accordingly.
Wind4Greg
requested review from
msporny,
martyr280 and
seabass-labrax
as code owners
TallTed
approved these changes
Feb 28, 2024
dlongley
approved these changes
Feb 28, 2024
msporny
added
CR1
msporny
approved these changes
Apr 28, 2024
|
Normative, multiple reviews, changes requested and made, no objections, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #52 and explicitly cites the CBOR RFC8949 and introduces normative language that implementers MUST NOT use CBOR tags when encoding components that make up a proof in the ECDSA-SD (base and derived proofs). This PR also updates the ECDSA-SD test vectors accordingly.
Preview | Diff