Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update of PADI, includes suggestions of issue #96 #104

Closed
wants to merge 2 commits into from
Closed

update of PADI, includes suggestions of issue #96 #104

wants to merge 2 commits into from

Conversation

RieksJ
Copy link

@RieksJ RieksJ commented Jul 1, 2019

This PR consists of stuff that I suggested to add in issue #96.

Since I wasn't sure how this relates to the Expert Diver focal use case (the text there forces me to make various assumptions that I'm not comfortable with), I have left a remark in the 'needs' section of the task I added that this still needs to be done.


Preview | Diff

@stonematt
Copy link
Contributor

good catch. This process should be part of the Verify Claim task, rather than it's own task. A revocation and status check is part of the verification process, as stated in the Datamodel in section 5.1:

A verifier verifies the authenticity of the presented verifiable presentation and verifiable credentials. This should include checking the credential status for revocation of the verifiable credentials.

Rather than make a new user task, let's update section 4.3 of the Use Cases.

Recommend: Reject this PR and make a new PR for Verify Claim.

@stonematt stonematt closed this Jul 19, 2019
@RieksJ
Copy link
Author

RieksJ commented Jul 21, 2019

@stonematt: can you explain how this works? I put effort in making a contribution, and then get confronted with a comment that doesn't respond to whay I intended to say, and my contribution gets rejected. Is this how it is done (i.e. without any discussion) or did I miss something?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants