Skip to content
This repository has been archived by the owner on Jan 6, 2022. It is now read-only.

Fixed where snipperChooser gets it URL from #69

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

murray3k
Copy link

@murray3k murray3k commented Dec 7, 2020

Since wagtail 2.11.1 the snippetChooser gets its URL from a data-attribute and longer from chooserUrls in the global scope.
This should fix the issue and be backwards compatible, by checking if snippetChooser exists in window.chooserUrls or else getting it from the data-attribute.

Since wagtail 2.11.1 the snippetChooser gets its URL from a data-attribute and longer from chooserUrls in the global scope.
This should fix the issue and be backwards compatible.
@oladhari
Copy link

any advancement in this fix?

@oladhari
Copy link

@murray3k do you have an idea when they will merge your PR? I really need this fix, were you able to resolve it?

@oladhari
Copy link

@BertrandBordage is there any possibility to add this PR? thank you

@thibaudcolas
Copy link
Contributor

thibaudcolas commented Jan 6, 2022

For people interested in this for Wagtail 2.11 compatibility, @kedmundson has made a branch including the fix from this PR and committing the project’s static files to git, so the fix can be installable without publishing to pypi.

I have just un-archived this project and pushed the branch here so it’s easier to find: https://github.com/wagtail/wagtail-react-streamfield/tree/pr-69-wagtail-2.11-snippetchooser-fix. With pip, you can install this from GitHub’s ZIP archives of branches:

pip install https://github.com/wagtail/wagtail-react-streamfield/archive/pr-69-wagtail-2.11-snippetchooser-fix.zip

I would only recommend this for people still using Wagtail 2.11 and unable to upgrade at this time. Otherwise the wagtail-react-streamfield project is no longer supported as we’ve merged most functionality in Wagtail 2.13.

I’ll archive this again now – people still using this can discuss further on the Wagtail Slack in #react-streamfield.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants