Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: key string capitalization issue #320

Closed
wants to merge 0 commits into from

Conversation

Brass-neck
Copy link
Contributor

image
image

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


章璋 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link

netlify bot commented Jan 24, 2025

Deploy Preview for midscene ready!

Name Link
🔨 Latest commit f68b6f3
🔍 Latest deploy log https://app.netlify.com/sites/midscene/deploys/6793606247c8df000842f3fe
😎 Deploy Preview https://deploy-preview-320--midscene.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@yuyutaotao
Copy link
Collaborator

HI @Brass-neck ,
modify this file : packages/web-integration/src/common/tasks.ts , about line 297.

it should looks like this

function mapToStandardKeyCode(input:string) {
  // ...
}

// ...
            executor: async (taskParam) => {
              assert(taskParam?.value, 'No key to press');
              const  key = mapToStandardKeyCode(taskParam.value);
              assert(key, 'cannot map ....');
              await this.page.keyboard.press(key);
            },

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants