This repository has been archived by the owner on Nov 6, 2019. It is now read-only.
Opt-out of "headless" mode #606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of [1] (merged on 2018-09-24), the WPT CLI enables the "headless" mode of Chrome and Firefox by default. This mode is more convenient for contributors running the tests from their development system, but it also relies on functionality which is not enabled during typical usage of the browsers. Results collected in this mode are therefore less authentic than results collected using a virtual display. @jgraham commented on this in [2]: > unless we have some reasonable assurance that headless mode matches > non-headless in all cases (e.g. the relevant browser running both > configurations in CI with identical results) I don't think we should > enable it for wpt.fyi-ingested runs. That issue includes evidence that the results are not equivalent, meaning "headless" mode is not appropriate for publicly documenting the capabilities of each browser. Extend the results collection system to use the new `--no-headless` command-line argument. [1] web-platform-tests/wpt#13076 [2] web-platform-tests#603
jgraham
approved these changes
Sep 24, 2018
Hexcles
approved these changes
Sep 24, 2018
|
Merged and deployed. Thanks for the review! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of [1] (merged on 2018-09-24), the WPT CLI enables the "headless"
mode of Chrome and Firefox by default. This mode is more convenient for
contributors running the tests from their development system, but it
also relies on functionality which is not enabled during typical usage
of the browsers. Results collected in this mode are therefore less
authentic than results collected using a virtual display.
@jgraham commented on this in [2]:
That issue includes evidence that the results are not equivalent,
meaning "headless" mode is not appropriate for publicly documenting the
capabilities of each browser.
Extend the results collection system to use the new
--no-headlesscommand-line argument.
[1] web-platform-tests/wpt#13076
[2] #603