fix(cli-plugin-dependencies): verify dependencies (#4483)

webiny · Jan 9, 2025 · ebf90f6 · ebf90f6
1 parent 621f49c
commit ebf90f6
Show file tree

Hide file tree

Showing 7 changed files with 33 additions and 25 deletions.
diff --git a/.github/workflows/pullRequests.yml b/.github/workflows/pullRequests.yml
@@ -3,7 +3,7 @@
 # and run "github-actions-wac build" (or "ghawac build") to regenerate this file.
 # For more information, run "github-actions-wac --help".
 name: Pull Requests
-"on": pull_request
+'on': pull_request
 concurrency:
   group: pr-${{ github.event.pull_request.number }}
   cancel-in-progress: true
@@ -19,7 +19,7 @@ jobs:
       - uses: webiny/[email protected]
     runs-on: ubuntu-latest
     env:
-      NODE_OPTIONS: "--max_old_space_size=4096"
+      NODE_OPTIONS: '--max_old_space_size=4096'
       YARN_ENABLE_IMMUTABLE_INSTALLS: false
   validateCommitsDev:
     name: Validate commit messages (dev branch, 'feat' commits not allowed)
@@ -34,7 +34,7 @@ jobs:
           allowed-commit-types: fix,docs,style,refactor,test,build,perf,ci,chore,revert,merge,wip
     runs-on: ubuntu-latest
     env:
-      NODE_OPTIONS: "--max_old_space_size=4096"
+      NODE_OPTIONS: '--max_old_space_size=4096'
       YARN_ENABLE_IMMUTABLE_INSTALLS: false
   constants:
     name: Create constants
@@ -87,7 +87,7 @@ jobs:
           $GITHUB_OUTPUT
     runs-on: ubuntu-latest
     env:
-      NODE_OPTIONS: "--max_old_space_size=4096"
+      NODE_OPTIONS: '--max_old_space_size=4096'
       YARN_ENABLE_IMMUTABLE_INSTALLS: false
   assignMilestone:
     name: Assign milestone
@@ -117,7 +117,7 @@ jobs:
           milestone: ${{ steps.get-milestone-to-assign.outputs.milestone }}
     runs-on: ubuntu-latest
     env:
-      NODE_OPTIONS: "--max_old_space_size=4096"
+      NODE_OPTIONS: '--max_old_space_size=4096'
       YARN_ENABLE_IMMUTABLE_INSTALLS: false
   build:
     name: Build
@@ -149,7 +149,7 @@ jobs:
           path: ${{ github.base_ref }}/.webiny/cached-packages
           key: ${{ needs.constants.outputs.run-cache-key }}
     env:
-      NODE_OPTIONS: "--max_old_space_size=4096"
+      NODE_OPTIONS: '--max_old_space_size=4096'
       YARN_ENABLE_IMMUTABLE_INSTALLS: false
   staticCodeAnalysis:
     needs:
@@ -190,7 +190,7 @@ jobs:
         working-directory: ${{ github.base_ref }}
     runs-on: ubuntu-latest
     env:
-      NODE_OPTIONS: "--max_old_space_size=4096"
+      NODE_OPTIONS: '--max_old_space_size=4096'
       YARN_ENABLE_IMMUTABLE_INSTALLS: false
   staticCodeAnalysisTs:
     name: Static code analysis (TypeScript)
@@ -216,7 +216,7 @@ jobs:
         run: yarn cy:ts
         working-directory: ${{ github.base_ref }}
     env:
-      NODE_OPTIONS: "--max_old_space_size=4096"
+      NODE_OPTIONS: '--max_old_space_size=4096'
       YARN_ENABLE_IMMUTABLE_INSTALLS: false
   jestTestsNoStorageConstants:
     needs:
@@ -244,7 +244,7 @@ jobs:
           echo '${{
           steps.list-packages-to-jest-test.outputs.packages-to-jest-test }}'
     env:
-      NODE_OPTIONS: "--max_old_space_size=4096"
+      NODE_OPTIONS: '--max_old_space_size=4096'
       YARN_ENABLE_IMMUTABLE_INSTALLS: false
   jestTestsNoStorageRun:
     needs:
@@ -265,7 +265,7 @@ jobs:
           }}
     runs-on: ${{ matrix.os }}
     env:
-      NODE_OPTIONS: "--max_old_space_size=4096"
+      NODE_OPTIONS: '--max_old_space_size=4096'
       YARN_ENABLE_IMMUTABLE_INSTALLS: false
       AWS_REGION: eu-central-1
     if: needs.jestTestsNoStorageConstants.outputs.packages-to-jest-test != '[]'
@@ -363,7 +363,7 @@ jobs:
           echo '${{
           steps.list-packages-to-jest-test.outputs.packages-to-jest-test }}'
     env:
-      NODE_OPTIONS: "--max_old_space_size=4096"
+      NODE_OPTIONS: '--max_old_space_size=4096'
       YARN_ENABLE_IMMUTABLE_INSTALLS: false
   jestTestsddbRun:
     needs:
@@ -383,7 +383,7 @@ jobs:
           fromJson(needs.jestTestsddbConstants.outputs.packages-to-jest-test) }}
     runs-on: ${{ matrix.os }}
     env:
-      NODE_OPTIONS: "--max_old_space_size=4096"
+      NODE_OPTIONS: '--max_old_space_size=4096'
       YARN_ENABLE_IMMUTABLE_INSTALLS: false
       AWS_REGION: eu-central-1
     if: needs.jestTestsddbConstants.outputs.packages-to-jest-test != '[]'
@@ -480,7 +480,7 @@ jobs:
           echo '${{
           steps.list-packages-to-jest-test.outputs.packages-to-jest-test }}'
     env:
-      NODE_OPTIONS: "--max_old_space_size=4096"
+      NODE_OPTIONS: '--max_old_space_size=4096'
       YARN_ENABLE_IMMUTABLE_INSTALLS: false
   jestTestsddb-esRun:
     needs:
@@ -501,7 +501,7 @@ jobs:
           }}
     runs-on: ${{ matrix.os }}
     env:
-      NODE_OPTIONS: "--max_old_space_size=4096"
+      NODE_OPTIONS: '--max_old_space_size=4096'
       YARN_ENABLE_IMMUTABLE_INSTALLS: false
       AWS_REGION: eu-central-1
       AWS_ELASTIC_SEARCH_DOMAIN_NAME: ${{ secrets.AWS_ELASTIC_SEARCH_DOMAIN_NAME }}
@@ -610,7 +610,7 @@ jobs:
           echo '${{
           steps.list-packages-to-jest-test.outputs.packages-to-jest-test }}'
     env:
-      NODE_OPTIONS: "--max_old_space_size=4096"
+      NODE_OPTIONS: '--max_old_space_size=4096'
       YARN_ENABLE_IMMUTABLE_INSTALLS: false
   jestTestsddb-osRun:
     needs:
@@ -631,7 +631,7 @@ jobs:
           }}
     runs-on: ${{ matrix.os }}
     env:
-      NODE_OPTIONS: "--max_old_space_size=4096"
+      NODE_OPTIONS: '--max_old_space_size=4096'
       YARN_ENABLE_IMMUTABLE_INSTALLS: false
       AWS_REGION: eu-central-1
       AWS_ELASTIC_SEARCH_DOMAIN_NAME: ${{ secrets.AWS_OPEN_SEARCH_DOMAIN_NAME }}

diff --git a/packages/cli-plugin-dependencies/package.json b/packages/cli-plugin-dependencies/package.json
@@ -16,6 +16,7 @@
   "dependencies": {
     "@babel/runtime": "^7.26.0",
     "@webiny/cli": "0.0.0",
+    "chalk": "^4.1.2",
     "get-yarn-workspaces": "^1.0.2",
     "glob": "^7.2.3",
     "load-json-file": "^6.2.0",

diff --git a/packages/cli-plugin-dependencies/src/references/DependencyTree.ts b/packages/cli-plugin-dependencies/src/references/DependencyTree.ts
@@ -82,9 +82,10 @@ export class DependencyTree implements IDependencyTree {
                 const semverVersion =
                     semver.validRange(version) || version === "beta" ? version : null;
                 if (!semverVersion) {
-                    console.log(
-                        `${version} is not a valid SemVer value in ${file}, package ${name}.`
-                    );
+                    process.env.DEBUG === "true" &&
+                        console.debug(
+                            `${version} is not a valid SemVer value in ${file}, package ${name}.`
+                        );
                     continue;
                 }
                 version = version

diff --git a/packages/cli-plugin-dependencies/src/references/verifyDependencies.ts b/packages/cli-plugin-dependencies/src/references/verifyDependencies.ts
@@ -2,6 +2,7 @@ import { IDependencyTree } from "~/types";
 import loadJsonFile from "load-json-file";
 import { getDuplicatesFilePath, getReferencesFilePath } from "~/references/files";
 import fs from "fs";
+import { green } from "chalk";
 
 export interface IVerifyDependenciesParams {
     tree: IDependencyTree;
@@ -26,6 +27,8 @@ export const verifyDependencies = (params: IVerifyDependenciesParams): void => {
         references: tree.references
     };
 
+    console.log("Checking references file...");
+
     if (fs.existsSync(referencesFile)) {
         const json = loadJsonFile.sync(referencesFile);
         if (JSON.stringify(references) !== JSON.stringify(json)) {
@@ -39,6 +42,8 @@ export const verifyDependencies = (params: IVerifyDependenciesParams): void => {
         );
     }
 
+    console.log("Checking duplicates file...");
+
     if (fs.existsSync(duplicatesFile)) {
         const json = loadJsonFile.sync(duplicatesFile);
         if (JSON.stringify(tree.duplicates) !== JSON.stringify(json)) {
@@ -52,5 +57,5 @@ export const verifyDependencies = (params: IVerifyDependenciesParams): void => {
         );
     }
 
-    console.log("All package reference files are in sync.");
+    console.log(green("✅  All package reference files are in sync."));
 };
diff --git a/packages/cli/files/references.json b/packages/cli/files/references.json
diff --git a/packages/system-requirements/package.json b/packages/system-requirements/package.json
@@ -15,8 +15,8 @@
   "dependencies": {
     "chalk": "^4.1.2",
     "cli-table3": "^0.6.5",
-    "execa": "^5.0.0",
-    "semver": "^7.3.5"
+    "execa": "^5.1.1",
+    "semver": "^7.6.3"
   },
   "license": "MIT",
   "publishConfig": {

diff --git a/yarn.lock b/yarn.lock
@@ -15087,6 +15087,7 @@ __metadata:
     "@babel/runtime": "npm:^7.26.0"
     "@webiny/cli": "npm:0.0.0"
     "@webiny/project-utils": "npm:0.0.0"
+    chalk: "npm:^4.1.2"
     execa: "npm:^5.1.1"
     get-yarn-workspaces: "npm:^1.0.2"
     glob: "npm:^7.2.3"
@@ -16262,8 +16263,8 @@ __metadata:
   dependencies:
     chalk: "npm:^4.1.2"
     cli-table3: "npm:^0.6.5"
-    execa: "npm:^5.0.0"
-    semver: "npm:^7.3.5"
+    execa: "npm:^5.1.1"
+    semver: "npm:^7.6.3"
   bin:
     webiny: ./bin.js
   languageName: unknown