Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(admin-ui): DataTable + Skeleton components #4489

Open
wants to merge 18 commits into
base: feat/new-admin-ui
Choose a base branch
from

Conversation

leopuleo
Copy link
Contributor

@leopuleo leopuleo commented Jan 13, 2025

Changes

This PR introduces two new components and improves many others.

Skeleton

The Skeleton component displays the loading state throughout the admin app. It follows the shadcn/ui specifications and may be updated as we await the final designs.

The previous Skeleton component used the react-loading-skeleton package, now removed.

Table + DataTable

These two components are used to display data across multiple admin app views. The Table component provides the backbone components and is used internally by DataTable, which handles data and column definitions.

The DataTable component will receive improvements in the future, migrating it to a first-test architecture approach.

Other improvements

Checkbox
Integrating the Checkbox component within the DataTable revealed several enhancements:

  • The label prop is no longer required, enhancing component alignment when not supplied.
  • We are forcing the check icon size and color: while using it inside a DropdownMenu component, its size and color were slightly odd.

How Has This Been Tested?

Jest + Manual

@leopuleo leopuleo requested a review from adrians5j January 13, 2025 14:21
@leopuleo leopuleo self-assigned this Jan 13, 2025
@leopuleo leopuleo marked this pull request as ready for review January 13, 2025 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants