Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: forbid data variables with the same name on instance #4771

Merged
merged 2 commits into from
Jan 22, 2025
Merged

Conversation

TrySound
Copy link
Member

Ref #4768

We don't want to allow data variables on one instance with the same name. Though we will allow child variables to mask parent ones in another PR.

To test:

  • create variable var1 on box
  • try to create another variable with var1
  • create variable var2
  • try to rename it to var1
  • create variable on body with var1

Ref #4768

We don't want to allow data variables on one instance with the same
name. Though we will allow child variables to mask parent ones in
another PR.
@TrySound TrySound requested a review from kof January 22, 2025 10:19
Copy link
Member

@kof kof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens with the existing variables which have the same name?

@TrySound
Copy link
Member Author

Nothing, users will get the error when try to edit them. Though I doubt anybody name variables the same.

@TrySound TrySound merged commit 7376743 into main Jan 22, 2025
15 checks passed
@TrySound TrySound deleted the dup-var branch January 22, 2025 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants