Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Cleanup duplicate closing HTML #1330

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nschonni
Copy link
Member

Few things flagged when I ran a Prettier check (even though it's not used), as it complains about HTML that it couldn't parse from the extra tags.

@j-paquette
Copy link
Contributor

Hi,
Could you remove sitemenu-eng.html, sitemenu-fra.html from the PR?
These files are automatically downloaded from an external source (intranet.canada.ca) and are not updated by cdts.
These external sources are listed in here: https://github.com/wet-boew/cdts-sgdc/blob/master/ExternalResGatherer.js
Let me know if you have questions,
Thank you

@nschonni
Copy link
Member Author

Do you know where those would be updated upstream? Thought https://github.com/wet-boew/cdts-DotNetTemplates/blob/master/WebForms/GoC.WebTemplate/StaticFallbackFiles/gcintranet/secMenuTop-en.html might have been the source, but doesn't have the same issue

@j-paquette
Copy link
Contributor

Hi,
I don't know where these pages are updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants