Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZF-Expressive support #178

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

ZF-Expressive support #178

wants to merge 11 commits into from

Conversation

popovserhii
Copy link

Many thanks for this great package. I really appreciate.

This PR adds support for ZF-Expressive application. If you agree to accept this I'll add description how it to use.

@widmogrod
Copy link
Owner

@popovserhii thank you for your contribution.

I haven't used ZF-Expressive so it would be awesome if you could instruction how to use it.

Also IF you could fix composer issues.

@popovserhii
Copy link
Author

popovserhii commented Jan 29, 2018

"How to" has been added.
I'm sorry but I never work with Symfony\CS and cannot fix composer error

@widmogrod
Copy link
Owner

@popovserhii please replace content of the file .php_cs and run composer fix this should fix the problem.

<?php
$finder = PhpCsFixer\Finder::create()
    ->exclude('vendor')
    ->in(__DIR__);
return PhpCsFixer\Config::create()
    ->setUsingCache(true)
    ->setRules([
        '@PSR2' => true,
        'encoding' => true,
        'braces' => true,
        'elseif' => true,
        'no_spaces_after_function_name' => true,
        'function_declaration' => true,
        'indentation_type' => true,
        'blank_line_after_namespace' => true,
        'line_ending' => true,
        'lowercase_constants' => true,
        'lowercase_keywords' => true,
        'no_closing_tag' => true,
        'single_line_after_imports' => true,
        'no_trailing_whitespace' => true,
        'visibility_required' => true,
        'whitespace_after_comma_in_array' => true,
        'blank_line_after_opening_tag' => true,
        'no_empty_statement' => true,
        'no_extra_consecutive_blank_lines' => true,
        'function_typehint_space' => true,
        'no_leading_namespace_whitespace' => true,
        'no_blank_lines_after_class_opening' => true,
        'no_blank_lines_after_phpdoc' => true,
        'phpdoc_scalar' => true,
        'phpdoc_types' => true,
        'no_leading_import_slash' => true,
        'no_extra_consecutive_blank_lines' => ['use'],
        'blank_line_before_return' => true,
        'self_accessor' => true,
        'no_short_bool_cast' => true,
        'no_trailing_comma_in_singleline_array' => true,
        'no_singleline_whitespace_before_semicolons' => true,
        'cast_spaces' => true,
        'standardize_not_equals' => true,
        'ternary_operator_spaces' => true,
        'trim_array_spaces' => true,
        'no_unused_imports' => true,
        'no_whitespace_in_blank_line' => true,
        'header_comment' => false,
        'linebreak_after_opening_tag' => true,
        'array_syntax' => ['syntax' => 'short'],
        'phpdoc_align' => true,
    ])
    ->setFinder($finder);

@fabiang
Copy link
Contributor

fabiang commented Dec 1, 2020

@popovserhii If you're still interested in Mezzio support, I've it now in my fork here: https://packagist.org/packages/fabiang/assetic-module#v3.0.0b1 It's hardly based in your work and I've tested it within a skeleton Mazzio application (sorry no Zend\Expressive support).

Would really appreciate, if you could test this and ping back if it's working for you. Thanks.

@popovserhii
Copy link
Author

@fabiang I don't work with Zend/Laminas products anymore. Sorry, I cannot test your changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants