[GAL-290] MavenChannel.resolve should validate any build specified in… #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the FPL against the builds provided by the channel
aloubyansky
reviewed
Sep 22, 2019
| @@ -115,7 +115,22 @@ public Path resolve(FeaturePackLocation fpl) throws MavenUniverseException { | |||
| artifact.setVersionRange(versionRange); | |||
| producer.getRepo().resolveLatestVersion(artifact, getFrequency(fpl), versionIncludePattern, versionExcludePattern); | |||
| } else { | |||
| artifact.setVersion(fpl.getBuild()); | |||
| String build = fpl.getBuild(); | |||
There was a problem hiding this comment.
Couldn't we simply check whether the specified build matches the version patterns of this channel instead?
There was a problem hiding this comment.
@aloubyansky We could but that doesn't deal with the user providing a build that is outside the version range or frequency of the channel.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… the FPL against the builds provided by the channel
https://issues.jboss.org/browse/GAL-290
This goes beyond the specific issue in that it should catch other cases where the specified build does not match what the channel provides (frequency or version range.)
This isn't a particularly elegant solution, but it seemed like adding an overloaded resolve method to MavenRepoManager to pass in the channel's various constraints would end up with an impl that does much the same kind of thing.
@aloubyansky or @jfdenise if you have any suggestions for how to test this please let me know. I added tests for GAL-280 that involve specifying a particular build but they must not be exercising the GAL-290 call path.