Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate the core-tck-runner for Jakarta EE 11 Core Profile. #186

Merged
merged 5 commits into from
Oct 22, 2024
Merged

Migrate the core-tck-runner for Jakarta EE 11 Core Profile. #186

merged 5 commits into from
Oct 22, 2024

Conversation

jamezp
Copy link
Member

@jamezp jamezp commented Oct 1, 2024

No description provided.

@jamezp jamezp force-pushed the ee11-core-profile branch 3 times, most recently from 62471d8 to 7caaad3 Compare October 2, 2024 17:32
@starksm64
Copy link
Contributor

@jamezp I have updated the https://github.com/jakartaee/platform-tck/tree/main/core-profile-tck for EE 11. Can you re-verify this against that?

@jamezp
Copy link
Member Author

jamezp commented Oct 9, 2024

@starksm64 running now

@jamezp jamezp force-pushed the ee11-core-profile branch 5 times, most recently from 7511c2f to ae53991 Compare October 9, 2024 20:04
bstansberry
bstansberry reviewed Oct 9, 2024
View reviewed changes
Copy link
Contributor

@bstansberry bstansberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jamezp I've got a coupe minor points and then some questions.

I'm guessing the REST TCK tests something involving mail. Which I guess is ok if the spec/TCK don't require Jakarta Mail and the various mail-oriented stuff in this PR is because of RESTEasy implementation choices.

.github/workflows/core-profile-tck-ee11-snapshot.yml Outdated Show resolved Hide resolved
.github/workflows/core-profile-tck-ee11-snapshot.yml Outdated Show resolved Hide resolved
core-profile/core-tck/pom.xml Outdated Show resolved Hide resolved
core-profile/rest-tck/pom.xml Outdated Show resolved Hide resolved
@jamezp jamezp force-pushed the ee11-core-profile branch from 5ed3cbb to fa0b01b Compare October 9, 2024 22:53
@bstansberry
Copy link
Contributor

LGTM. I'll not formally approve as it's still a draft.

@jamezp jamezp force-pushed the ee11-core-profile branch 3 times, most recently from 9b4aec8 to 9e48057 Compare October 15, 2024 15:49
@jamezp jamezp marked this pull request as ready for review October 15, 2024 15:58
@jamezp jamezp force-pushed the ee11-core-profile branch from 35da706 to 9e48057 Compare October 15, 2024 16:06
bstansberry
bstansberry reviewed Oct 15, 2024
View reviewed changes
core-profile/cdi-langmodel-tck/pom.xml Outdated Show resolved Hide resolved
core-profile/cdi-langmodel-tck/pom.xml Outdated Show resolved Hide resolved
@jamezp jamezp force-pushed the ee11-core-profile branch from 9e48057 to e611b6e Compare October 15, 2024 17:50
@jamezp
Copy link
Member Author

jamezp commented Oct 15, 2024

I think I've addressed all the comments and hopefully it's a little more clear now.

@jamezp jamezp merged commit 325f2c2 into wildfly:main Oct 22, 2024
3 checks passed
@jamezp jamezp deleted the ee11-core-profile branch October 22, 2024 15:09
@starksm64
Copy link
Contributor

There is an 11.0.0.M1 release candidate of the CDI EE TCK in the staged area:
https://www.eclipse.org/downloads/download.php?file=/ee4j/jakartaee-tck/jakartaee11/staged/eftl/cdi-ee-tck-11.0.0.M1-dist.zip

The artifact has also been staged to the repo and released to maven central using the GAV
jakarta.tck:cdi-ee-tck-dist:11.0.0.M1

@jamezp
Copy link
Member Author

jamezp commented Oct 24, 2024

Excellent. I'll file an issue and give it a test for the upgrade.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bstansberry bstansberry bstansberry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jamezp @starksm64 @bstansberry