-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New "Docker and Kubernetes" category in Guides #676
base: main
Are you sure you want to change the base?
New "Docker and Kubernetes" category in Guides #676
Conversation
_data/guides.yaml
Outdated
- title: Java Microservices on Kubernetes with WildFly | ||
url: /guides/get-started-microservices-on-kubernetes | ||
description: Build and run Jakarta EE applications with WildFly on Kubernetes in a few minutes | ||
- category: Docker and Kubernetes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Containers
instead?
I think we should move away from using the Docker (which is one of the tool to build & run containers but there are others such as Podman) and focus on the container (which is also what is run by Kubernetes)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jmesnil Thank you for your suggestion! that was somewhat intentional: the assumption is that most audience knows what Docker is but might be confused by the term "container" alone .... the guides actually use Podman and specify that Docker can be used as an alternative .... my assumption might be wrong (I did it based solely on my personal experience): let me know if you want to switch to "Podman" or "Container"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to bump this discussion forward - @jmesnil do you still stand by your comment?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jmesnil changed to "Podman/Docker and Kubernetes" ... I've seen this around ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tommaso-borgato Sounds reasonable to me. 👍🏼 Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As said on the chat, please don't call this Docker. It's a private closed-source company with proprietary software. Use 'Containers' when speaking generally.
6a17e8b
to
b4bd3af
Compare
@rhusar what about #676 (comment) ? |
b4bd3af
to
ea25cb4
Compare
# Conflicts: # guides/get-started-microservices-on-kubernetes/_includes/_constants.adoc # guides/get-started-microservices-on-kubernetes/simple-microservice-client-part1.adoc # guides/get-started-microservices-on-kubernetes/simple-microservice-client-part2.adoc
ea25cb4
to
42a8d1c
Compare
</div> | ||
</div> | ||
{% endfor %} | ||
{% else %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be:
{% endif %}
{% if item.guides %}
Otherwise the entire category must be used solely for guides that are part of groups.
This will conflict with #712 and will need to be updated to put the new category in the correct alphabetical position. |
This PR moves the "WildFly mini Series" index up one level into the "Guides" page by creating a new "Docker and Kubernetes" category:
"Draft" because this MR is based upon #671 and has to be re-based & merged afterwards