Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New "Docker and Kubernetes" category in Guides #676

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

tommaso-borgato
Copy link
Contributor

@tommaso-borgato tommaso-borgato commented Oct 25, 2024

This PR moves the "WildFly mini Series" index up one level into the "Guides" page by creating a new "Docker and Kubernetes" category:

image

"Draft" because this MR is based upon #671 and has to be re-based & merged afterwards

@tommaso-borgato tommaso-borgato changed the title New "Docker and kubernetes" category in Guides New "Docker and Kubernetes" category in Guides Oct 25, 2024
@tommaso-borgato tommaso-borgato marked this pull request as draft October 25, 2024 14:21
- title: Java Microservices on Kubernetes with WildFly
url: /guides/get-started-microservices-on-kubernetes
description: Build and run Jakarta EE applications with WildFly on Kubernetes in a few minutes
- category: Docker and Kubernetes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Containers instead?

I think we should move away from using the Docker (which is one of the tool to build & run containers but there are others such as Podman) and focus on the container (which is also what is run by Kubernetes)

Copy link
Contributor Author

@tommaso-borgato tommaso-borgato Oct 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jmesnil Thank you for your suggestion! that was somewhat intentional: the assumption is that most audience knows what Docker is but might be confused by the term "container" alone .... the guides actually use Podman and specify that Docker can be used as an alternative .... my assumption might be wrong (I did it based solely on my personal experience): let me know if you want to switch to "Podman" or "Container"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to bump this discussion forward - @jmesnil do you still stand by your comment?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jmesnil changed to "Podman/Docker and Kubernetes" ... I've seen this around ...

image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tommaso-borgato Sounds reasonable to me. 👍🏼 Thanks.

Copy link
Member

@rhusar rhusar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As said on the chat, please don't call this Docker. It's a private closed-source company with proprietary software. Use 'Containers' when speaking generally.

@tommaso-borgato
Copy link
Contributor Author

As said on the chat, please don't call this Docker. It's a private closed-source company with proprietary software. Use 'Containers' when speaking generally.

@rhusar what about #676 (comment) ?

# Conflicts:
#	guides/get-started-microservices-on-kubernetes/_includes/_constants.adoc
#	guides/get-started-microservices-on-kubernetes/simple-microservice-client-part1.adoc
#	guides/get-started-microservices-on-kubernetes/simple-microservice-client-part2.adoc
</div>
</div>
{% endfor %}
{% else %}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be:

{% endif %}
{% if item.guides %}

Otherwise the entire category must be used solely for guides that are part of groups.

@bstansberry
Copy link
Contributor

This will conflict with #712 and will need to be updated to put the new category in the correct alphabetical position.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants