-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add php8.1 enum support #54
base: master
Are you sure you want to change the base?
Conversation
Hey @tdumalin, thanks a lot for your contribution! I would need to sit into how to properly solve it here. Also, such code would require to be available only with PHP8.1 enabled |
Yes indeed, I've seen the build errors and parseError could not be avoided in php < 8.1. The only solution would be to add php version in composer.json but it will be very tricky to manage. |
Hey! What do you guys think about skipping these tests for PHP <8.1? Skipping examples can be used for that: if (version_compare(PHP_VERSION, '8.1.0', '<')) {
throw new \PhpSpec\Exception\Example\SkippingException('Requires at least PHP 8.1.');
} |
@coldic3 , |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @tdumalin, I see tests passed 🙂
I've added some small comments. I also wonder if the states
key in the configuration might not be required while using enum 🤔
Co-authored-by: Kevin Kaniaburka <[email protected]>
Co-authored-by: Kevin Kaniaburka <[email protected]>
Co-authored-by: Kevin Kaniaburka <[email protected]>
Co-authored-by: Kevin Kaniaburka <[email protected]>
Co-authored-by: Kevin Kaniaburka <[email protected]>
Co-authored-by: Kevin Kaniaburka <[email protected]>
Co-authored-by: Kevin Kaniaburka <[email protected]>
Hi,
I've created an issue on StateMachineBundle (#70) but i realized that it's on this repo that we have to work.
So this is an implementation for php8.1 enum support, let me know what do you think.