Add warnings if multiple JSX renderers are used #12887
Conversation
🦋 Changeset detectedLatest commit: 4952d07 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
pkg: react
louisescher
changed the title
|
I think the issue is core doesn't have access to the integrations options so it can't check include/exclude |
|
@florian-lefebvre is correct. Core would've been the better solution but it can't see what options are passed |
|
I don't see any issue at all. We could expose a utility from |
|
@ematipico Is that just for the known renderers so that the integration can throw the warning? I'd be happy to implement it there |
|
Yeah just for the known JSX renderers, it seems |
There was a problem hiding this comment.
I'm personally happy with this current approach to keep things simple. I don't know if we need to expose a new API here to avoid the hardcoding. The downside with that is that integrations will require a newer version of Astro, so if the end-user only upgrades the integration and not Astro, it'll fail to import in runtime, which is a breaking change.
| @@ -71,6 +71,14 @@ export default function ({ include, exclude, compat, devtools }: Options = {}): | |||
| injectScript('page', 'import "preact/debug";'); | |||
| } | |||
| }, | |||
| 'astro:config:done': ({ logger, config }) => { | |||
| const knownJsxRenderers = ['@astrojs/react', '@astrojs/preact', '@astrojs/solid-js']; | |||
There was a problem hiding this comment.
Vue can also be used in jsx files if configured this way
There was a problem hiding this comment.
I wasn't sure at first, should I add Vue to that list then? I figured it might cause wrong errors since Vue can also be used without JSX and could be used just fine alongside React
There was a problem hiding this comment.
You're right. I think I would only show it from inside the vue integration if it has jsx enabled
Changes
includeorexcludeoptions when using multiple UI frameworks together.Testing
As this is just a warning printed to console, no tests have been added.
Docs
As this is just a warning printed to console, no docs have been added.