Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Initial implementation for OIDC with machines #50

Draft
wants to merge 21 commits into
base: main
Choose a base branch
from

Conversation

johannwagner
Copy link
Contributor

@johannwagner johannwagner commented Jun 11, 2024

Note: PR is marked as ready for CI purposes.

To-Do-List:

  • Remove anyhow in vickyctl and implement proper error handling
  • Better error handling
  • Finish implementation in vickyctl
  • Clean-up http_client handling in fairy
  • Replace client, vicky_url construct with some proper wrapped thing.

@johannwagner johannwagner force-pushed the feature/oidc-machines branch from 7a0f58b to 40aa78f Compare June 16, 2024 18:35
@johannwagner johannwagner marked this pull request as ready for review June 16, 2024 21:54
@johannwagner johannwagner force-pushed the feature/oidc-machines branch from 838c61a to 9c0fc12 Compare June 16, 2024 21:57
@johannwagner johannwagner changed the title feat: Initial (non-working) implementation for OIDC with machines feat: Initial implementation for OIDC with machines Jun 16, 2024
@Kek5chen Kek5chen force-pushed the feature/oidc-machines branch from caabbed to de752f2 Compare June 18, 2024 12:35
@Kek5chen
Copy link
Contributor

brought it back onto main

@Kek5chen Kek5chen marked this pull request as draft June 20, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants