-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Catch and log exceptions thrown when actions can't be created, e.g. under a corrupt database schema #1000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lsinger
requested review from
vedanshujain,
a team and
barryhughes
and removed request for
a team and
vedanshujain
October 9, 2023 13:40
barryhughes
reviewed
Oct 11, 2023
barryhughes
reviewed
Oct 11, 2023
lsinger
force-pushed
the
fix/invalid-schema-exceptions-not-caught
branch
from
October 24, 2023 14:53
10cfe70
to
0933485
Compare
…er uncaught exception there
barryhughes
approved these changes
Oct 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, thank you.
- Confirmed a (potentially site-breaking) exception occurs without this change (when the priority column is missing).
- Confirmed an exception does not occur when this branch is checkout out, and that appropriate error messages are logged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to address parts of #973 by catching and logging the exceptions that are thrown when actions can't be created. If, e.g., a database schema migration did not complete properly, scheduling an action has been able to render a site inaccessible because exceptions just bubbled up to the user.
This PR explicitly does not solve completing or fixing incomplete schema migrations -- that's a different task. The first step implemented here is to lessen the impact of such issues.
To test this manually, you could take a working site with AS running fine and then drop the priority column. Without this PR the exceptions thrown when trying to schedule actions bubble up to the user, with this PR applied they're merely logged. AS isn't functional then but at least we limit the damage.
Alternatively apply the commits from this branch sequentially and run the test suite in between:
Changelog