Improve the messaging in our unidentified action exceptions. #1060
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We trigger
InvalidArgumentExceptions
from a number of locations, all with the same basic message:This is not particularly helpful, and conveys no information about what was happening at the time the exception was thrown. This change adds some additional context to a number of these exception messages.
Updates #1059 (but does not close).
Testing instructions
This PR changes the text of various exception messages, but there are no functional changes to the way the library works. Manual testing will therefore have limited value, but I've still provided some basic instructions to see the change in action.
✍🏼 Note that you need to have access to the system/PHP error log, or some other way to view errors logged via
error_log()
calls:If that seems a little verbose, note that the first half (everything before
Reason:
) is added by the List Table implementation when it catches the exception.Changelog