Refactor extension and test download logic with separate endpoints #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Luc45 saw you requested review but this is still in draft, just wanted to check if it's meant to be ready or still a WIP. Thanks! |
Sorry, misclicked. I'll remove the review request for now to do a final pass on this PR and mark it as ready for review again. |
zhongruige
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the rules for downloading extensions and tests by introducing two separate endpoints - one for extensions and one for tests. It clarifies access control for both WPORG and WCCOM extensions:
Having separate endpoints simplifies the authorization flow and helps avoid issues (e.g., slugs that don't exist in either marketplace).