Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove verification status and add test coverage for ppcp-gateway #33

Merged
merged 3 commits into from
Jan 24, 2025

Conversation

chrismccluskey
Copy link
Collaborator

Changes proposed in this Pull Request

  • Remove $verification_status from ppcp-gateway implementation - it was incorrect and I'm not sure right now what the correct field is.
  • Add test coverage for ppcp-gateway payment method with mock classes.

Testing instructions

  • Automated tests are included.

Mentions p1737531613946049/1737021980.939599-slack-C9J8248EB

Copy link

Code Coverage

Package Line Rate Complexity Health
inc/payment-gateways/index.php 0% 0
inc/payment-gateways/lib/stripe.php 63% 77
inc/payment-gateways/load.php 0% 0
inc/payment-gateways/ppcp-gateway.php 31% 26
inc/payment-gateways/stripe.php 26% 17
inc/payment-gateways/transact.php 100% 0
inc/payment-gateways/woocommerce-payments.php 30% 8
inc/sift-decisions/abuse-decisions.php 0% 14
inc/sift-decisions/sift-decision-rest-api-webhooks.php 0% 10
inc/sift-events/class-sift-event-types.php 100% 4
inc/sift-events/normalizers/sift-order.php 96% 6
inc/sift-events/normalizers/sift-payment-gateway.php 100% 5
inc/sift-events/normalizers/sift-payment-method.php 97% 31
inc/sift-events/normalizers/sift-payment-type.php 83% 3
inc/sift-events/normalizers/sift-property.php 100% 3
inc/sift-events/normalizers/sift-verification-status.php 50% 3
inc/sift-events/sift-events-validator.php 85% 140
inc/sift-events/sift-events.php 71% 126
inc/tracking-js.php 0% 4
inc/wc-admin-settings-tab.php 0% 24
index.php 0% 0
sift-for-woocommerce.php 14% 11
Summary 55% (1054 / 1905) 512

Copy link
Collaborator

@chrisfromthelc chrisfromthelc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests appear to be passing, so LGTM.

@chrismccluskey chrismccluskey merged commit 9dfe13b into trunk Jan 24, 2025
12 checks passed
@chrismccluskey chrismccluskey deleted the add/test-coverage-for-ppcp-gateway branch January 24, 2025 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants