Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix e2e tests: Update default behavior to use a block-based cart and checkout #171

Merged
merged 9 commits into from
Nov 10, 2023

Conversation

iamdharmesh
Copy link
Member

All Submissions:

  • Does your code follow the WooCommerce Sniffs variant of WordPress coding standards?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Will this change require new documentation or changes to existing documentation?

Changes proposed in this Pull Request:

Cart and Checkout Blocks is now the default experience with WooCommerce 8.3. current e2e tests have shortcode cart and checkout as a default. This PR updates the default behavior to block-based cart and checkout.

Steps to test the changes in this Pull Request:

Make sure E2E tests run successfully locally and in GH action.

Changelog entry

Dev - Update default behavior to use a block-based cart and checkout in E2E tests.

@iamdharmesh
Copy link
Member Author

@ravinderk Tests are failing in GH action while it is passing in local env. I tried 2-3 times and it pass every time. As you have worked on this, do you have any idea of the known issue of this failure?

@ravinderk
Copy link
Contributor

@ravinderk Tests are failing in GH action while it is passing in local env. I tried 2-3 times and it pass every time. As you have worked on this, do you have any idea of the known issue of this failure?

@iamdharmesh I fixed the broken test. I also added a fix for the flaky test which we discussed.

Copy link
Contributor

@ravinderk ravinderk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good

@ravinderk ravinderk requested a review from dkotter November 9, 2023 16:09
@dkotter dkotter modified the milestones: Future Release, 1.6.0 Nov 10, 2023
@dkotter dkotter marked this pull request as ready for review November 10, 2023 14:40
@dkotter dkotter merged commit 570013a into trunk Nov 10, 2023
7 checks passed
@dkotter dkotter deleted the fix/e2e-tests branch November 10, 2023 14:40
@vikrampm1 vikrampm1 mentioned this pull request Nov 17, 2023
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants