-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add composable middleware #164
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…show the same results
PaulAsjes
commented
Jan 8, 2025
@@ -26,7 +26,10 @@ jest.mock('next/headers', () => { | |||
get: jest.fn((name: string) => cookieStore.get(name)), | |||
getAll: jest.fn(() => Array.from(cookieStore.entries())), | |||
set: jest.fn((name: string, value: string | { [key: string]: string | number | boolean }) => | |||
cookieStore.set(name, value), | |||
cookieStore.set(name, { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Next always stores its cookies in the format
{
name: string;
value: string;
...other options
}
so changed this to reflect what next actually does.
dandorman
reviewed
Jan 9, 2025
dandorman
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #47
Right now we only give users the option to use
authkitMiddleware
as a drop-in middleware replacement. This works fine if you only want to use middleware for auth purposes, but in more complex apps you might want to stitch together multiple middleware functionalities.This introduces
authkit
as a middleware function that allows you to compose middleware yourself at the expense of some of the automatic redirecting and "secure by default" functionality ofauthkitMiddleware
.Example use: