3.12.2 - fix loading animation #2337
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue #2336:
In Theme Engine v1
WPEC_Fancy_NotificationsJS component, the 'add to basket' loading animation is hidden even when fancy notifications is not active in admin settings.This PR only adds the Fancy Notifications JS if the Presentation Options is selected in the admin.
This PR is only tested with Theme Engine v1.
Future-wise I'm not sure in TE2 wether we should still be loading the JS to despatch add to basket events for Fancy Notifications, just removing the listeners?
Having said that, there is a lot of traction at the moment on the WP Trac ticket for adding JavaScript actions and filters to core. Once something like that makes it into core it would make more sense to build the "add to basket" event using that framework so it is hackable via JS. https://core.trac.wordpress.org/ticket/21170