Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loosen image version check #681

Merged
merged 3 commits into from
Oct 19, 2023

Conversation

calcmogul
Copy link
Member

@calcmogul calcmogul commented Oct 18, 2023

The 2024 image doesn't have an "FRC_" prefix.

Fixes wpilibsuite/2024Beta#6.

The 2024 image doesn't have an "FRC_" prefix.
Copy link
Member

@PeterJohnson PeterJohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 139 needs to be updated to use group 2, since you've added a new group. Although I'm not sure how exactly this works when the group is optional...

@PeterJohnson
Copy link
Member

We could make this more robust with a named-capture group (?<version>...) and then use group("version")

@PeterJohnson PeterJohnson merged commit 6b722c0 into wpilibsuite:main Oct 19, 2023
6 checks passed
@calcmogul calcmogul deleted the loosen-image-version-check branch October 19, 2023 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid Image Exception, roboRIO image is missing the FRC_ prefix
2 participants