Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POC for login only mode option #303

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

POC for login only mode option #303

wants to merge 1 commit into from

Conversation

nilasini
Copy link
Contributor

@nilasini nilasini commented Jan 23, 2025

Proposed changes in this pull request

We will be adding all the endpoints which needs to disabled as below in resource-access-control-v2.xml.j2 file and allow to change the value resource_access_control.login_only_mode.enable through deployment.toml file.

{% if resource_access_control.login_only_mode.enable is sameas true %}

<Resource context="(.*)/scim2/Users(.*)"  access-control="deny" secured="true" http-method="POST">
        <Scopes>internal_user_mgt_create</Scopes>
    </Resource>
{% endif %}

Copy link

codecov bot commented Jan 23, 2025

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 3.65%. Comparing base (00ba557) to head (213ceff).
Report is 7 commits behind head on master.

Files with missing lines Patch % Lines
...n/identity/auth/service/module/ResourceConfig.java 0.00% 3 Missing ⚠️
...ntity/auth/service/util/AuthConfigurationUtil.java 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             master    #303      +/-   ##
===========================================
- Coverage      3.66%   3.65%   -0.02%     
  Complexity       20      20              
===========================================
  Files            36      36              
  Lines          1529    1534       +5     
  Branches        254     254              
===========================================
  Hits             56      56              
- Misses         1472    1477       +5     
  Partials          1       1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant