Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the SMS handler to default in username recovery notify. #864

Merged

Conversation

Malith-19
Copy link
Contributor

Proposed changes in this pull request

  • $title

Problem

  • The current sms handler is not working in the username recovery notification since it requires user mobile number and other properties as properties in the event.

@CLAassistant
Copy link

CLAassistant commented Oct 15, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

codecov bot commented Oct 15, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 36.04%. Comparing base (a4ed43e) to head (2536b16).
Report is 158 commits behind head on master.

Files with missing lines Patch % Lines
...ice/impl/username/UsernameRecoveryManagerImpl.java 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             master     #864       +/-   ##
=============================================
+ Coverage     22.15%   36.04%   +13.88%     
- Complexity      915     1450      +535     
=============================================
  Files           267      267               
  Lines         15472    15790      +318     
  Branches       2092     2182       +90     
=============================================
+ Hits           3428     5691     +2263     
+ Misses        11590     9384     -2206     
- Partials        454      715      +261     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RushanNanayakkara RushanNanayakkara merged commit f8d0c11 into wso2-extensions:master Oct 15, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants