Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a listener to resolve shared profile based on SharedProfileValueResolvingMethod #427

Merged

Conversation

AnuradhaSK
Copy link
Contributor

@AnuradhaSK AnuradhaSK commented Jan 22, 2025

Purpose

Add doPostGetUserClaimValuesWithID, doPostGetUsersClaimValuesWithID and doPostGetUserClaimValueWithID methods to resolve the shared profiles based on SharedProfileValueResolvingMethod claim property in each claim property.
Part of wso2/product-is#22126

Related PRs

Depends on

Copy link

codecov bot commented Jan 22, 2025

Codecov Report

Attention: Patch coverage is 70.81340% with 61 lines in your changes missing coverage. Please review.

Project coverage is 48.98%. Comparing base (c226a8e) to head (fa50618).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
...ing/listener/SharedUserOperationEventListener.java 70.81% 50 Missing and 11 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #427      +/-   ##
============================================
+ Coverage     48.28%   48.98%   +0.70%     
- Complexity     1202     1237      +35     
============================================
  Files           141      141              
  Lines          7611     7820     +209     
  Branches        938      967      +29     
============================================
+ Hits           3675     3831     +156     
- Misses         3622     3665      +43     
- Partials        314      324      +10     
Flag Coverage Δ
unit 37.14% <70.81%> (+1.77%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AnuradhaSK AnuradhaSK force-pushed the resolve-shared-user-profile branch from 67fa6a5 to 629d107 Compare January 22, 2025 12:53
@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12928049334

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12928049334
Status: success

Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/12928049334

@AnuradhaSK AnuradhaSK merged commit e885b6a into wso2-extensions:main Jan 23, 2025
4 checks passed
@AnuradhaSK AnuradhaSK deleted the resolve-shared-user-profile branch January 23, 2025 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants