Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add getLocalClaim service to claim meta data mgt service #6245

Merged
merged 2 commits into from
Jan 2, 2025

Conversation

AnuradhaSK
Copy link
Contributor

@AnuradhaSK AnuradhaSK commented Jan 1, 2025

Proposed changes in this pull request

Expose a new service as getLocalClaim in the claim meta data mgt service to retrieve a local claim specifying the claim URI and tenant domain.
If this introduced claim is not available, the invoker has to list all the local claims and filter the required local claim which is time and resource consuming.

When should this PR be merged

No other dependency

Copy link

sonarqubecloud bot commented Jan 1, 2025

Copy link

codecov bot commented Jan 1, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 45.70%. Comparing base (f70492e) to head (0a53c7e).
Report is 20 commits behind head on master.

Files with missing lines Patch % Lines
...m/metadata/mgt/ClaimMetadataManagementService.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             master    #6245    +/-   ##
==========================================
  Coverage     45.69%   45.70%            
+ Complexity    14078    14059    -19     
==========================================
  Files          1633     1633            
  Lines        100914   100658   -256     
  Branches      17730    17696    -34     
==========================================
- Hits          46117    46005   -112     
+ Misses        48080    47957   -123     
+ Partials       6717     6696    -21     
Flag Coverage Δ
unit 28.40% <75.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12570505436

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12570505436
Status: failure

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12571771503

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12571771503
Status: success

Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/12571771503

@AnuradhaSK AnuradhaSK merged commit 83387a9 into wso2:master Jan 2, 2025
5 checks passed
@AnuradhaSK AnuradhaSK deleted the getLocalClaimService branch January 2, 2025 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants