-
Notifications
You must be signed in to change notification settings - Fork 545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CustomCXFNonSpringJaxrsServlet #6316
Conversation
PR builder started |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6316 +/- ##
============================================
- Coverage 46.32% 46.14% -0.18%
+ Complexity 14694 14599 -95
============================================
Files 1695 1695
Lines 104024 103844 -180
Branches 18580 18243 -337
============================================
- Hits 48190 47921 -269
- Misses 48988 49058 +70
- Partials 6846 6865 +19
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
PR builder completed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/12879990971
PR builder started |
PR builder completed |
PR builder started |
PR builder completed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/12882718447
components/servlet-mgt/org.wso2.carbon.identity.servlet.mgt/pom.xml
Outdated
Show resolved
Hide resolved
components/servlet-mgt/org.wso2.carbon.identity.servlet.mgt/pom.xml
Outdated
Show resolved
Hide resolved
components/servlet-mgt/org.wso2.carbon.identity.servlet.mgt/pom.xml
Outdated
Show resolved
Hide resolved
...ntity.servlet.mgt/src/main/java/org/wso2/carbon/identity/servlet/mgt/CustomObjectMapper.java
Outdated
Show resolved
Hide resolved
...t.mgt/src/main/java/org/wso2/carbon/identity/servlet/mgt/CustomCXFNonSpringJaxrsServlet.java
Outdated
Show resolved
Hide resolved
...t.mgt/src/main/java/org/wso2/carbon/identity/servlet/mgt/CustomCXFNonSpringJaxrsServlet.java
Outdated
Show resolved
Hide resolved
...t.mgt/src/main/java/org/wso2/carbon/identity/servlet/mgt/CustomCXFNonSpringJaxrsServlet.java
Outdated
Show resolved
Hide resolved
...t.mgt/src/main/java/org/wso2/carbon/identity/servlet/mgt/CustomCXFNonSpringJaxrsServlet.java
Show resolved
Hide resolved
...t.mgt/src/main/java/org/wso2/carbon/identity/servlet/mgt/CustomCXFNonSpringJaxrsServlet.java
Outdated
Show resolved
Hide resolved
...t.mgt/src/main/java/org/wso2/carbon/identity/servlet/mgt/CustomCXFNonSpringJaxrsServlet.java
Outdated
Show resolved
Hide resolved
...t.mgt/src/main/java/org/wso2/carbon/identity/servlet/mgt/CustomCXFNonSpringJaxrsServlet.java
Outdated
Show resolved
Hide resolved
...t.mgt/src/main/java/org/wso2/carbon/identity/servlet/mgt/CustomCXFNonSpringJaxrsServlet.java
Outdated
Show resolved
Hide resolved
...t.mgt/src/main/java/org/wso2/carbon/identity/servlet/mgt/CustomCXFNonSpringJaxrsServlet.java
Outdated
Show resolved
Hide resolved
...t.mgt/src/main/java/org/wso2/carbon/identity/servlet/mgt/CustomCXFNonSpringJaxrsServlet.java
Outdated
Show resolved
Hide resolved
...t.mgt/src/main/java/org/wso2/carbon/identity/servlet/mgt/CustomCXFNonSpringJaxrsServlet.java
Outdated
Show resolved
Hide resolved
32c39df
to
89724fc
Compare
eba6833
to
277fee4
Compare
277fee4
to
0373b5a
Compare
Quality Gate failedFailed conditions See analysis details on SonarQube Cloud Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE |
Out of the 3 High Severity issues two of them are about reducing the cognitive complexity, which cannot be resolved as the nested conditions are required and the remaining one is about repitition of a string in error messages. |
Proposed changes in this pull request
[List all changes you want to add here. If you fixed an issue, please
add a reference to that issue as well.]
When should this PR be merged
[Please describe any preconditions that need to be addressed before we
can merge this pull request.]
Follow up actions
[List any possible follow-up actions here; for instance, testing data
migrations, software that we need to install on staging and production
environments.]
Checklist (for reviewing)
General
Functionality
Code
Tests
Security
Documentation