Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for rule evaluation in action execution. #6324

Merged
merged 4 commits into from
Jan 23, 2025

Conversation

malithie
Copy link
Member

Proposed changes in this pull request

Resolves wso2/product-is#22348

This PR incorporates rule evaluation at action execution updating the core action execution service to invoke rule evaluation service.

Copy link

codecov bot commented Jan 22, 2025

Codecov Report

Attention: Patch coverage is 42.18750% with 37 lines in your changes missing coverage. Please review.

Project coverage is 46.30%. Comparing base (244f9cb) to head (4f5f60f).
Report is 47 commits behind head on master.

Files with missing lines Patch % Lines
...xecution/util/ActionExecutionDiagnosticLogger.java 0.00% 18 Missing ⚠️
...tion/internal/ActionExecutionServiceComponent.java 0.00% 16 Missing ⚠️
...tion/execution/impl/ActionExecutorServiceImpl.java 88.88% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6324      +/-   ##
============================================
+ Coverage     45.85%   46.30%   +0.44%     
- Complexity    14547    14743     +196     
============================================
  Files          1696     1701       +5     
  Lines        105122   104006    -1116     
  Branches      18886    18559     -327     
============================================
- Hits          48204    48159      -45     
+ Misses        50015    48995    -1020     
+ Partials       6903     6852      -51     
Flag Coverage Δ
unit 29.86% <42.18%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12905110350

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12905110350
Status: success

Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/12905110350

@malithie malithie merged commit f7bae7f into wso2:master Jan 23, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invoke rule evaluation at action execution
4 participants