Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call app-mgt component to handle inbound details #543

Merged
merged 17 commits into from
Mar 12, 2024

Conversation

sahandilshan
Copy link
Contributor

Purpose

With the wso2/carbon-identity-framework#5146 improvement, we just need to call the app-mgt component to handle the inbound OAuth and SAML protocol details. We don't have to explicitly call each inbound admin service from the API level to handle those protocols.

Goals

Prevent calling Inbound Auth Admin services directly from API level when doing CRUD operations to an application

Approach

image

*** Note:
Framework, Inbound OAuth and SAML versions should be updated

- With wso2/carbon-identity-framework#5146 improvement, we just need to call the app-mgt component to handle the inbound OAuth and SAML protocol details. We don't have to explicitly call each inbound admin services from API level to handle those protocols.
@sahandilshan sahandilshan marked this pull request as draft November 27, 2023 09:18
@VivekVinushanth VivekVinushanth marked this pull request as ready for review February 21, 2024 03:43
@VivekVinushanth
Copy link
Contributor

Build is failing without any changes and the core team is checking on it.

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/8182270764

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/8182270764
Status: failure

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/8182517983

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/8182517983
Status: failure

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/8198973464

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/8198973464
Status: failure

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/8199160487

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/8199160487
Status: failure

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/8199511921

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/8199511921
Status: failure

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/8214245831

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/8214245831
Status: success

Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/8214245831

@VivekVinushanth VivekVinushanth merged commit f1974d0 into wso2:master Mar 12, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants