Set BLOB as the property type of Google Outbound Provisioning Private Key #579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR builder started |
|
PR builder completed |
jenkins-is-staging
approved these changes
Jan 22, 2024
There was a problem hiding this comment.
Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/7609152792
madurangasiriwardena
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Resolves wso2/product-is#19049
Approach
When creating/updating the IDP via managemnt console, from the SOAP requests we are setting the property type of
google_prov_private_keyas a BLOB and due to that we are saving it as a BLOB.[1]But when we creating/updating the IDP via new console, form the API server we didn't set the property type for the
google_prov_private_keyand due to that we are getting below errorValue too long for column "PROPERTY_VALUE CHARACTER VARYING(2048)So set BLOB as the property type of Google Outbound Provisioning Private Key.
[1] https://github.com/wso2/carbon-identity-framework/blob/610b6a595cb865320720b3884b188507dcc5587b/components/idp-mgt/org.wso2.carbon.idp.mgt.ui/src/main/java/org/wso2/carbon/idp/mgt/ui/util/IdPManagementUIUtil.java#L483-L488