Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Action Management REST API to manage actions with rules #770

Merged
merged 3 commits into from
Jan 9, 2025

Conversation

malithie
Copy link
Member

@malithie malithie commented Jan 7, 2025

Purpose

Resolves wso2/product-is#22197

When it comes to extensions it should be possible to let to invoke extensions conditionally based on some rule applicable to the context.
This PR improves action management api layer component to facilitate add/update actions with rules.

Dependent on wso2/carbon-identity-framework#6269

@malithie malithie requested a review from ashanthamara January 7, 2025 16:34
@malithie malithie force-pushed the action-rule-management branch from 65bc9bc to 04f338b Compare January 8, 2025 11:28
@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12691266715

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12691266715
Status: failure

@malithie
Copy link
Member Author

malithie commented Jan 9, 2025

Resolves wso2/product-is#22197

Failure is as below, which seems to have failed in consecutive set of runs. Passes locally. More over as there's no direct relation. So will proceed with the merge

OAuth2ServiceAuthCodeGrantTestCase.testAuthzCodeGrantRetry:323 SessionDataKeyConsent key value is null expected object to not be null

@malithie malithie merged commit 77ac8c2 into wso2:master Jan 9, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve Action Management REST API to manage actions with rules
4 participants