Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue of retrieving client ID before authenticating it #212

Merged
merged 3 commits into from
May 29, 2024

Conversation

Akila94
Copy link
Member

@Akila94 Akila94 commented May 20, 2024

Fix issue of retrieving client ID before authenticating it

This PR fixes the issue of retrieving the client ID from the auth header before the request is authenticated.

Issue link: #184
Related issue: https://github.com/wso2-enterprise/ob-compliance-toolkit-berlin/issues/185

Doc Issue: Optional, link issue from documentation repository

Applicable Labels: ob-3.0.0, Berlin


Development Checklist

  1. Built complete solution with pull request in place.
  2. Ran checkstyle plugin with pull request in place.
  3. Ran Findbugs plugin with pull request in place.
  4. Ran FindSecurityBugs plugin and verified report.
  5. Formatted code according to WSO2 code style.
  6. Have you verify the PR does't commit any keys, passwords, tokens, usernames, or other secrets?
  7. Migration scripts written (if applicable).
  8. Have you followed secure coding standards in WSO2 Secure Engineering Guidelines?

Testing Checklist

  1. Written unit tests.
  2. Documented test scenarios(link available in guides).
  3. Written automation tests (link available in guides).
  4. Verified tests in multiple database environments (if applicable).
  5. Verified tests in multiple deployed specifications (if applicable).
  6. Tested with OBBI enabled (if applicable).
  7. Tested with specification regulatory conformance suites (if applicable).

Automation Test Details

Test Suite Test Script IDs
Integration Suite TCXXXXX, TCXXXX

Conformance Tests Details

Test Suite Name Test Suite Version Scenarios Result
Security Suite VX.X Foo, Bar Passed

Resources

Knowledge Base: https://sites.google.com/wso2.com/open-banking/

Guides: https://sites.google.com/wso2.com/open-banking/developer-guides

@Akila94 Akila94 force-pushed the signature-validation-fix branch from 7929fa6 to b633a8b Compare May 27, 2024 06:54
@imesh94 imesh94 added the Ready-to-Build Trigger Git action to build the repository. label May 27, 2024
@imesh94 imesh94 merged commit 5b17405 into wso2:main May 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready-to-Build Trigger Git action to build the repository.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants