chore: remove and update dependencies as in upstream #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was quite a bit of changes in the upstream repo which I would consider very valuable as they remove many dependencies that can be easily replaced by native Node modules (
mkdirp,fs-extra) or replace outdated ones with modern alternatives (e.g.bunyan).It doesn't however actually sync with upstream as there were many unrelated changes and it was a bit easier to just create a new commit.
Also, a ton of the commits from upstream are from dependabot, because the dependencies versions are frozen. We could consider changing dependencies versions in package.json to include caret to ease the maintenance burden a little, but that I didn't want to make the decision.