Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Properly close readline instance on close #1278

Merged
merged 1 commit into from
Dec 25, 2024
Merged

Conversation

aklinker1
Copy link
Collaborator

Copy link

netlify bot commented Dec 13, 2024

Deploy Preview for creative-fairy-df92c4 ready!

Name Link
🔨 Latest commit 932cd7b
🔍 Latest deploy log https://app.netlify.com/sites/creative-fairy-df92c4/deploys/675c51891d2cae0008375445
😎 Deploy Preview https://deploy-preview-1278--creative-fairy-df92c4.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

pkg-pr-new bot commented Dec 13, 2024

Open in Stackblitz

@wxt-dev/auto-icons

npm i https://pkg.pr.new/@wxt-dev/auto-icons@1278

@wxt-dev/i18n

npm i https://pkg.pr.new/@wxt-dev/i18n@1278

@wxt-dev/module-solid

npm i https://pkg.pr.new/@wxt-dev/module-solid@1278

@wxt-dev/module-react

npm i https://pkg.pr.new/@wxt-dev/module-react@1278

@wxt-dev/module-svelte

npm i https://pkg.pr.new/@wxt-dev/module-svelte@1278

@wxt-dev/module-vue

npm i https://pkg.pr.new/@wxt-dev/module-vue@1278

@wxt-dev/storage

npm i https://pkg.pr.new/@wxt-dev/storage@1278

@wxt-dev/unocss

npm i https://pkg.pr.new/@wxt-dev/unocss@1278

wxt

npm i https://pkg.pr.new/wxt@1278

commit: 932cd7b

Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.38%. Comparing base (0137d79) to head (932cd7b).
Report is 26 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1278      +/-   ##
==========================================
+ Coverage   81.18%   81.38%   +0.20%     
==========================================
  Files         128      128              
  Lines        6286     6284       -2     
  Branches     1065     1070       +5     
==========================================
+ Hits         5103     5114      +11     
+ Misses       1168     1155      -13     
  Partials       15       15              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aklinker1
Copy link
Collaborator Author

This was not the cause, closing.

@aklinker1 aklinker1 closed this Dec 17, 2024
@aklinker1
Copy link
Collaborator Author

Nevermind, this might help. Reopening.

@aklinker1 aklinker1 reopened this Dec 17, 2024
@aklinker1 aklinker1 marked this pull request as ready for review December 25, 2024 15:40
@aklinker1 aklinker1 merged commit 0bf7279 into main Dec 25, 2024
31 checks passed
@aklinker1 aklinker1 deleted the close-readline branch December 25, 2024 15:40
@aklinker1
Copy link
Collaborator Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant