Starts periodic schedule automatically #6212
Conversation
Remove dependency from Xapi. The function "loop_start" allows to set a wrapper for the thread loop if needed. Signed-off-by: Frediano Ziglio <[email protected]>
|
What is the problem being addressed here? Some more motivation in the commit message would be useful. I can see that the client code becomes simpler. |
|
I don't really understand it either... and the code in xapi.ml does not become simpler. |
The root rationale was more reuse. The code was moved from Xapi to separate library in order to be reused (to rewrite some C code for forkexecd work in Ocaml) but moving to a separate directory is not enough, the code currently depends on the assumption that Xapi launch the scheduler loop in a separate thread. So to be transparent the loop is automatically created. Suggestion on how to improve the commit message? |
|
IMO it is more transparent if the user of the library creates the thread... |
Remove dependency from Xapi.
The function "loop_start" allows to set a wrapper for the thread loop if needed.