CA-403700 use iso9660 file system for updates #6216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Be explicit about the file system of an update ISO. Remove dead code. Signed-off-by: Christian Lindig <[email protected]>
freddy77
reviewed
Jan 9, 2025
Comment on lines
-2468
to
+2469
| with_mounted_dir_ro path @@ fun dir -> | ||
| let filename = Filename.concat dir "suspend-image" in | ||
| Unixext.with_file filename [Unix.O_RDONLY] 0o600 f_synced | ||
| error "%s: can't mount %s" __FUNCTION__ path ; | ||
| internal_error "can't mount %s (not a file or block dev)" path |
There was a problem hiding this comment.
Are you sure you modified the hunk you wanted? This code is supposed to call f using f_synced on a file, which is what it was doing before this change.
freddy77
reviewed
Jan 9, 2025
| with_api_errors (mount device) mount_point ; | ||
| with_api_errors (mount ~ty:(Some "iso9660") device) mount_point ; |
There was a problem hiding this comment.
Not against, but what the advantage of doing this? A different error in some cases? What if in the future we want to change file system?
There was a problem hiding this comment.
This encodes our expectations. Any other format should be rejected; if we want to change the format we will change the code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Be explicit about the file system of an update ISO. Remove dead code.