Merge pull request #446 from xchem/m2m-1055

fix: target loader can process most recent data
xchem · Nov 14, 2023 · 30002cb · 30002cb
2 parents 36559f2 + 7f598ad
commit 30002cb
Showing 1 changed file with 13 additions and 4 deletions.
diff --git a/viewer/target_loader.py b/viewer/target_loader.py
@@ -814,10 +814,17 @@ def process_metadata(
 
         # add xtalform fk to experiment
         for _, obj in experiment_objects.items():
-            obj.instance.xtalform = xtalform_objects[
-                assigned_xtalforms[obj.instance.code]
-            ].instance
-            obj.instance.save()
+            try:
+                obj.instance.xtalform = xtalform_objects[
+                    assigned_xtalforms[obj.instance.code]
+                ].instance
+                obj.instance.save()
+            except KeyError:
+                # TODO: don't know at this point whether ignoring this
+                # error is a right thing to do
+                msg = f"xtalform {obj.instance.code} undefined for {obj}"
+                result.append(msg)
+                logger.warning(msg)
 
         quat_assembly_objects = {}
         for idx, obj in assemblies.items():
@@ -1332,6 +1339,8 @@ def load_target(
         update_task(task, "SUCCESS", upload_report)
         target_loader.experiment_upload.message = upload_report
 
+        logger.debug("%s", upload_report)
+
         target_loader.experiment_upload.save()