Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Add method to prepare extra step kwargs for scheduler in xFuserCogVideoXPipeline #426

Merged
merged 1 commit into from
Jan 11, 2025

Conversation

LazyBusyYang
Copy link
Contributor

@LazyBusyYang LazyBusyYang commented Jan 8, 2025

What's the problem

self.scheduler is an instance of xFuserDDIMSchedulerWrapper, whose step is defined like def step(self, *args, **kwargs). The original accepts_eta and accepts_generator are always false because set(inspect.signature(self.scheduler.step).parameters.keys()) returns a set of args and kwargs.

This update introduces the prepare_extra_step_kwargs method, which prepares additional keyword arguments for the scheduler step based on its signature. It checks for the presence of 'eta' and 'generator' parameters to ensure compatibility with different schedulers. This enhancement improves the flexibility and usability of the pipeline.

…eoXPipeline

This update introduces the `prepare_extra_step_kwargs` method, which prepares additional keyword arguments for the scheduler step based on its signature. It checks for the presence of 'eta' and 'generator' parameters to ensure compatibility with different schedulers. This enhancement improves the flexibility and usability of the pipeline.
@LazyBusyYang LazyBusyYang changed the title Draft: Add method to prepare extra step kwargs for scheduler in xFuserCogVid… Draft: [Fix] Add method to prepare extra step kwargs for scheduler in xFuserCogVideoXPipeline Jan 8, 2025
@LazyBusyYang LazyBusyYang changed the title Draft: [Fix] Add method to prepare extra step kwargs for scheduler in xFuserCogVideoXPipeline [Fix] Add method to prepare extra step kwargs for scheduler in xFuserCogVideoXPipeline Jan 8, 2025
@feifeibear feifeibear merged commit b2bcc38 into xdit-project:main Jan 11, 2025
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants