[FIX] - Gradle problem in buildAndTestSinglep and buildAndTestMultip (#…

…543) * Fix problem with exec and command executions, because we override and only execute the last commandLine by default
xebia-functional · Nov 15, 2023 · 934284d · 934284d
1 parent d1eafd9
commit 934284d
Showing 1 changed file with 32 additions and 40 deletions.
diff --git a/build.gradle.kts b/build.gradle.kts
@@ -15,59 +15,51 @@ allprojects {
     group = property("project.group").toString()
 }
 
-fun isMultiplatformModule(project: Project): Boolean {
-  val kotlinPluginId = "libs.plugins.kotlin.multiplatform"
-  return project.buildFile.readText().contains(kotlinPluginId)
-}
+fun Project.configureBuildAndTestTask(taskName: String, moduleType: ModulePlatformType) {
+  val platform: String by extra
+  val multiPlatformModules = project.subprojects.filter { isMultiPlatformModule(it) }.map { it.name }
 
-val multiPlatformModules = project.subprojects.filter { isMultiplatformModule(it) }.map { it.name }
+  tasks.register(taskName) {
+    val gradleCommand = getGradleCommand(platform)
 
-enum class ModuleType { SINGLEPLATFORM, MULTIPLATFORM }
+    doFirst {
+        project.exec {commandLine(gradleCommand, "spotlessCheck") }
+    }
 
-fun Project.configureBuildAndTestTask(
-  taskName: String,
-  moduleType: ModuleType,
-  multiPlatformModules: List<String>
-) {
-  val platform: String by extra
-  tasks.register(taskName) {
     doLast {
-      val gradleCommand = getGradleCommand(platform)
-      project.exec {
-        commandLine(gradleCommand, "spotlessCheck")
-      }
-      project.exec {
-        when (moduleType) {
-          ModuleType.SINGLEPLATFORM -> {
-            commandLine(gradleCommand, "build", *buildExcludeOptions(multiPlatformModules))
-          }
-          ModuleType.MULTIPLATFORM -> {
-            multiPlatformModules.forEach { module ->
-              commandLine(gradleCommand, ":$module:${platform}Test")
-            }
-          }
+      when (moduleType) {
+        ModulePlatformType.SINGLE -> {
+          val excludedModules = includeOrNotModulesToCommand(multiPlatformModules, platform, false)
+          project.exec { commandLine(gradleCommand, "build", *excludedModules) }
+        }
+        ModulePlatformType.MULTI -> {
+          val includedModules = includeOrNotModulesToCommand(multiPlatformModules, platform, true)
+          project.exec { commandLine(gradleCommand, *includedModules) }
         }
       }
     }
   }
 }
 
-fun buildExcludeOptions(modules: List<String>): Array<String> {
-  return modules.flatMap { listOf("-x", ":$it:build") }.toTypedArray()
+enum class ModulePlatformType { SINGLE, MULTI }
+
+fun isMultiPlatformModule(project: Project): Boolean {
+    val kotlinPluginId = "libs.plugins.kotlin.multiplatform"
+    return project.buildFile.readText().contains(kotlinPluginId)
+}
+
+fun includeOrNotModulesToCommand(modules: List<String>, platform: String, include: Boolean): Array<String> {
+    return modules.flatMap {
+        when (include) {
+            true -> listOf(":$it:${platform}Test")
+            false -> listOf("-x", ":$it:build")
+        }
+    }.toTypedArray()
 }
 
 fun getGradleCommand(platform: String): String {
   return if (platform == "mingwX64") "gradlew.bat" else "./gradlew"
 }
 
-configureBuildAndTestTask(
-  "buildAndTestMultip",
-  ModuleType.MULTIPLATFORM,
-  multiPlatformModules
-)
-
-configureBuildAndTestTask(
-  "buildAndTestSinglep",
-  ModuleType.SINGLEPLATFORM,
-  multiPlatformModules
-)
+configureBuildAndTestTask("buildAndTestMultip", ModulePlatformType.MULTI)
+configureBuildAndTestTask("buildAndTestSinglep", ModulePlatformType.SINGLE)