Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove support for Java and Scala #530

Merged
merged 5 commits into from
Nov 13, 2023
Merged

Remove support for Java and Scala #530

merged 5 commits into from
Nov 13, 2023

Conversation

tomascayuelas
Copy link
Contributor

@tomascayuelas tomascayuelas commented Nov 9, 2023 •
edited
Loading

Issue: #527

This PR remove all the support for Java and Scala, tell me if there are something that I forgot.

@tomascayuelas tomascayuelas self-assigned this Nov 9, 2023
@tomascayuelas tomascayuelas marked this pull request as ready for review November 9, 2023 13:28
@tomascayuelas tomascayuelas force-pushed the remove-support-java-scala branch from 1726ad5 to b95f4bc Compare November 9, 2023 13:29
@tomascayuelas tomascayuelas changed the title Remove support for Java and Scala [WIP] - Remove support for Java and Scala Nov 9, 2023
@tomascayuelas tomascayuelas marked this pull request as draft November 9, 2023 13:33
@tomascayuelas tomascayuelas changed the title [WIP] - Remove support for Java and Scala Remove support for Java and Scala Nov 9, 2023
@tomascayuelas tomascayuelas force-pushed the remove-support-java-scala branch from b95f4bc to cc4b9ff Compare November 9, 2023 13:42
@tomascayuelas tomascayuelas marked this pull request as ready for review November 9, 2023 13:56
@gerson24 gerson24 force-pushed the remove-support-java-scala branch from ff2a835 to 5b5d6e7 Compare November 9, 2023 14:14
@tomascayuelas tomascayuelas marked this pull request as draft November 9, 2023 14:16
@tomascayuelas tomascayuelas force-pushed the remove-support-java-scala branch 2 times, most recently from 667318e to 5e3daa2 Compare November 13, 2023 09:11
tomascayuelas and others added 3 commits November 13, 2023 10:18
@tomascayuelas
Remove support for Java and Scala
ae111d6
@gerson24 @tomascayuelas
Minor doc change
3b6a4d4
@tomascayuelas
- Removed: java and scala support
9ef456e 
- Removed: xef-kotlin module
- Removed: xef-gpt4all module
- xef-kotlin-examples renamed to xef-examples
@tomascayuelas tomascayuelas force-pushed the remove-support-java-scala branch from 5e3daa2 to 9ef456e Compare November 13, 2023 09:19
raulraja
raulraja approved these changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@raulraja raulraja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good and I think we should get it merged ASAP so we can proceed with the Open AI client refactor work without all these modules in the way.

@tomascayuelas tomascayuelas marked this pull request as ready for review November 13, 2023 19:13
@tomascayuelas tomascayuelas merged commit 7222268 into main Nov 13, 2023
5 checks passed
@tomascayuelas tomascayuelas deleted the remove-support-java-scala branch November 13, 2023 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raulraja raulraja raulraja approved these changes

Assignees

@tomascayuelas tomascayuelas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tomascayuelas @raulraja @gerson24