Update ChatWithFunctions.kt #547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raulraja
reviewed
Nov 17, 2023
There was a problem hiding this comment.
Maybe we should use here rangeTo https://kotlinlang.org/docs/ranges.html
|
Makes sense, I'll take a look and adapt the code 👍 |
fedefernandez
force-pushed
the
fix/chat-with-functions
branch
from
32dc531 to
1e0ee08
Compare
|
@raulraja the code has been adapted. Thanks |
raulraja
approved these changes
Nov 23, 2023
Montagon
approved these changes
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current loop never gets
if (currentAttempts == maxDeserializationAttempts)satisfied. This shifts the index to the right, so the condition is satisfied when the maximum is reached.