Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improves polymorphic serialization + tests #561

Merged
merged 7 commits into from
Dec 5, 2023
Merged

Improves polymorphic serialization + tests #561

merged 7 commits into from
Dec 5, 2023

Conversation

fedefernandez
Copy link
Contributor

@fedefernandez fedefernandez commented Nov 24, 2023 •
edited
Loading

This PR:

  • Moves models to individual files
  • Completes deserializer for the polymorphic types
  • Add tests for polymorphic serializations
  • Fixes some default args (default args could be omitted from the Json representation by the serializer, causing issues)

@fedefernandez fedefernandez marked this pull request as ready for review November 27, 2023 08:59
@fedefernandez fedefernandez reopened this Nov 29, 2023
raulraja
raulraja approved these changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@raulraja raulraja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Montagon
Montagon approved these changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@Montagon Montagon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@fedefernandez fedefernandez merged commit 5d4f9e9 into main Dec 5, 2023
6 checks passed
@fedefernandez fedefernandez deleted the polymorphic-serialization branch December 5, 2023 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Montagon Montagon Montagon approved these changes

@raulraja raulraja raulraja approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fedefernandez @raulraja @Montagon